Skip to content

Subject Overview Page cleanup #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 28, 2025
Merged

Subject Overview Page cleanup #1475

merged 9 commits into from
May 28, 2025

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented May 21, 2025 •
edited
Loading

General changes to line things up with the mock ups for each Subject Overview Page:

  • Adding symbols to explain practice and challenge difficulties
  • Including a greyed out option for GCSE Biology in the card list
    • (+ removing blanks from the card list on small screens)
  • Adding the example question deck to the bottom of the screen.
    • Physics hasn't made one yet. We can confirm it has the same id as the commented one and add it in fairly easily once available.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 21, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (4afc7c1) to head (f45bcc2).
Report is 83 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/components/pages/SubjectOverviewPage.tsx 38.46% 8 Missing ⚠️
...rc/app/components/elements/svg/DifficultyIcons.tsx 81.81% 2 Missing ⚠️
...ents/elements/list-groups/AbstractListViewItem.tsx 0.00% 1 Missing ⚠️
src/app/components/pages/SubjectLandingPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           redesign-2024    #1475      +/-   ##
=================================================
- Coverage          40.60%   40.45%   -0.15%     
=================================================
  Files                495      495              
  Lines              22087    22138      +51     
  Branches            6531     6541      +10     
=================================================
- Hits                8968     8957      -11     
- Misses             13082    13144      +62     
  Partials              37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjd210 sjd210 marked this pull request as ready for review May 22, 2025 14:06
github-advanced-security[bot]
github-advanced-security bot found potential problems May 22, 2025
View reviewed changes
axlewin
axlewin reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@axlewin axlewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a minor layout suggestion for the sample question deck

@axlewin axlewin merged commit 67a03f1 into redesign-2024 May 28, 2025
8 checks passed
@axlewin axlewin deleted the redesign/subject-overview-cleanup branch May 28, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlewin axlewin axlewin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjd210 @axlewin